Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: [[HomeObject]] is always an ordinary object #3407

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Editorial: [[HomeObject]] is always an ordinary object #3407

merged 1 commit into from
Oct 24, 2024
+8 −7

Conversation

anba
Copy link
Contributor

@anba anba commented Aug 27, 2024

[[HomeObject]] is always set to an ordinary object (or undefined). Assert this in MakeMethod and GetSuperBase. GetSuperBase and MakeSuperPropertyReference are now both also infallible.

@anba
Copy link
Contributor Author

anba commented Aug 27, 2024

GetSuperBase probably stopped being fallible when CloneMethod was removed (in February 2, 2015 Draft Rev 32).

bakkot
bakkot approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we ought to update the types of the various object-creation methods (PropertyDefinitionEvaluation, etc) to note that they take specifically an ordinary object? In a separate PR, though.

michaelficarra
michaelficarra approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Oct 23, 2024
@anba @ljharb
Editorial: [[HomeObject]] is always an ordinary object
fceabf7 
`[[HomeObject]]` is always set to an ordinary object (or `undefined`).
Assert this in `MakeMethod` and `GetSuperBase`. `GetSuperBase` and
`MakeSuperPropertyReference` are now both also infallible.
@ljharb ljharb merged commit fceabf7 into tc39:main Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anba @michaelficarra @bakkot @ljharb